Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove fire_event_if_test #65

Merged
merged 4 commits into from
Feb 8, 2024
Merged

remove fire_event_if_test #65

merged 4 commits into from
Feb 8, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Feb 6, 2024

resolves #66

Description

Remove fire_event_if_test as it's no longer used.

Checklist

Copy link

github-actions bot commented Feb 6, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f3c128) 52.21% compared to head (7e02a6b) 52.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #65   +/-   ##
=======================================
  Coverage   52.21%   52.21%           
=======================================
  Files          49       49           
  Lines        2863     2861    -2     
=======================================
- Hits         1495     1494    -1     
+ Misses       1368     1367    -1     
Flag Coverage Δ
unit 52.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop
Copy link
Member Author

emmyoop commented Feb 6, 2024

This is blocked on merging until all uses of this function have been removed.

@emmyoop emmyoop marked this pull request as ready for review February 7, 2024 20:27
@emmyoop emmyoop requested a review from a team as a code owner February 7, 2024 20:27
@emmyoop emmyoop requested a review from martynydbt February 7, 2024 20:27
@emmyoop emmyoop removed the request for review from martynydbt February 7, 2024 20:31
@emmyoop emmyoop added this pull request to the merge queue Feb 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 8, 2024
@emmyoop emmyoop added this pull request to the merge queue Feb 8, 2024
Merged via the queue into main with commit e4ecbf5 Feb 8, 2024
12 checks passed
@emmyoop emmyoop deleted the er/remove-fire_event_if_test branch February 8, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove fire_event_if_test
3 participants