Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade protobuf to >=5.0,<6.0 #219

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Upgrade protobuf to >=5.0,<6.0 #219

merged 4 commits into from
Nov 19, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Nov 12, 2024

resolves #218

Description

Upgrade protobuf to >=5.0,<=6.0

Checklist

@gshank gshank requested a review from a team as a code owner November 12, 2024 14:41
@cla-bot cla-bot bot added the cla:yes label Nov 12, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.50%. Comparing base (1c9da9f) to head (143dc67).

Files with missing lines Patch % Lines
dbt_common/events/types_pb2.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
+ Coverage   68.48%   68.50%   +0.01%     
==========================================
  Files          52       52              
  Lines        3389     3391       +2     
==========================================
+ Hits         2321     2323       +2     
  Misses       1068     1068              
Flag Coverage Δ
unit 68.50% <60.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gshank gshank changed the title Upgrade protobuf to >=5.0 Upgrade protobuf to >=5.0,<6.0 Nov 12, 2024
@gshank gshank added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit c82699d Nov 19, 2024
19 checks passed
@gshank gshank deleted the upgrade_protobuf branch November 19, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade protobuf to >=5.0
4 participants