Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade protobuf to >=5,<6 #211

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ewhauser
Copy link
Contributor

@ewhauser ewhauser commented Oct 19, 2024

resolves #

dbt-labs/dbt-core#9724

Description

This upgrade dbt-common so that it is compatible with protobuf 5.0 and greater.

Per protobuf release guidelines, there is no guarantee that major version upgrades are compatible across protobuf releases so dbt-core should change it's pinned protobuf version to the as dbt-common when it takes this dependency.

Checklist

@ewhauser ewhauser requested a review from a team as a code owner October 19, 2024 22:00
@cla-bot cla-bot bot added the cla:yes label Oct 19, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@MichelleArk
Copy link
Collaborator

MichelleArk commented Nov 4, 2024

As mentioned in the description, we'll need to bump dbt-core's install dependency on protobuf to mirror these requirements here: https://github.com/dbt-labs/dbt-core/blob/bdf28d7eff13edcbe0d41746e50ffa8edcfa3cf0/core/setup.py#L60

Looks like dbt-adapters would need a bump as well in their pyproject.toml: https://github.com/dbt-labs/dbt-adapters/blob/b12c9870d6134905ab09bfda609ce8f81bc4b40a/pyproject.toml#L31

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.50%. Comparing base (5a401a9) to head (2a3d70b).

Files with missing lines Patch % Lines
dbt_common/events/types_pb2.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   68.48%   68.50%   +0.01%     
==========================================
  Files          52       52              
  Lines        3389     3391       +2     
==========================================
+ Hits         2321     2323       +2     
  Misses       1068     1068              
Flag Coverage Δ
unit 68.50% <60.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ogescalante
Copy link

Nice 😄

@ewhauser
Copy link
Contributor Author

@MichelleArk - can I do anything to help get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants