-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade protobuf to >=5,<6 #211
base: main
Are you sure you want to change the base?
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
As mentioned in the description, we'll need to bump dbt-core's install dependency on protobuf to mirror these requirements here: https://github.com/dbt-labs/dbt-core/blob/bdf28d7eff13edcbe0d41746e50ffa8edcfa3cf0/core/setup.py#L60 Looks like dbt-adapters would need a bump as well in their pyproject.toml: https://github.com/dbt-labs/dbt-adapters/blob/b12c9870d6134905ab09bfda609ce8f81bc4b40a/pyproject.toml#L31 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
+ Coverage 68.48% 68.50% +0.01%
==========================================
Files 52 52
Lines 3389 3391 +2
==========================================
+ Hits 2321 2323 +2
Misses 1068 1068
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Nice 😄 |
@MichelleArk - can I do anything to help get this merged? |
resolves #
dbt-labs/dbt-core#9724
Description
This upgrade
dbt-common
so that it is compatible withprotobuf
5.0 and greater.Per
protobuf
release guidelines, there is no guarantee that major version upgrades are compatible acrossprotobuf
releases sodbt-core
should change it's pinned protobuf version to the asdbt-common
when it takes this dependency.Checklist
changie new
to create a changelog entry