Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "object" mergebehavior to MergeBehavior processing #192

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Sep 14, 2024

resolves #191

Description

Add a new type of MergeBehavior, "Object". Move the processing of config_call_dicts to the same file. Create tests for both types of merges.

Checklist

@gshank gshank requested a review from a team as a code owner September 14, 2024 15:28
@cla-bot cla-bot bot added the cla:yes label Sep 14, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 16 lines in your changes missing coverage. Please review.

Project coverage is 67.33%. Comparing base (9798ca7) to head (72506cb).

Files with missing lines Patch % Lines
dbt_common/contracts/config/base.py 66.66% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
+ Coverage   65.16%   67.33%   +2.17%     
==========================================
  Files          52       52              
  Lines        3333     3380      +47     
==========================================
+ Hits         2172     2276     +104     
+ Misses       1161     1104      -57     
Flag Coverage Δ
unit 67.33% <66.66%> (+2.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gshank gshank added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 16b683e Sep 18, 2024
16 checks passed
@gshank gshank deleted the object_mergebehavior branch September 18, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new "object" MergeBehavior to support snapshot column name ticket
3 participants