Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Type Annotations in jinja and semver Code #187

Merged
merged 7 commits into from
Sep 9, 2024
Merged

Conversation

peterallenwebb
Copy link
Contributor

@peterallenwebb peterallenwebb commented Sep 7, 2024

Description

Improves type annotation coverage.

Checklist

integration tests against dbt-core: https://github.com/dbt-labs/dbt-common/actions/runs/10775731441/job/29880840129

@cla-bot cla-bot bot added the cla:yes label Sep 7, 2024
Copy link

github-actions bot commented Sep 7, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@peterallenwebb peterallenwebb marked this pull request as ready for review September 7, 2024 21:34
@peterallenwebb peterallenwebb requested a review from a team as a code owner September 7, 2024 21:34
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 85.52632% with 11 lines in your changes missing coverage. Please review.

Project coverage is 65.16%. Comparing base (ce09ad3) to head (d3ccb68).

Files with missing lines Patch % Lines
dbt_common/clients/jinja.py 76.74% 10 Missing ⚠️
dbt_common/exceptions/jinja.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   65.08%   65.16%   +0.08%     
==========================================
  Files          52       52              
  Lines        3325     3333       +8     
==========================================
+ Hits         2164     2172       +8     
  Misses       1161     1161              
Flag Coverage Δ
unit 65.16% <85.52%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterallenwebb peterallenwebb added Skip Changelog Skips GHA to check for changelog file tidy_first labels Sep 7, 2024
@peterallenwebb peterallenwebb changed the title Add types to jinja-related files Add Type Annotations in jinja and semver Code Sep 9, 2024
@peterallenwebb peterallenwebb added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit 9798ca7 Sep 9, 2024
20 checks passed
@peterallenwebb peterallenwebb deleted the paw/jinja-typing branch September 9, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file tidy_first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants