Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add group property to records. Correct filter on file records. #169

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

peterallenwebb
Copy link
Contributor

resolves #

Description

This PR adds a "group" property to records that can be used to record, replay, or diff related records. The initial application of the group property will be to create a Database group in core and adapters which will apply to all records related to DB/DWH interaction.

Checklist

@peterallenwebb peterallenwebb requested a review from a team as a code owner July 16, 2024 15:24
@cla-bot cla-bot bot added the cla:yes label Jul 16, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 64.31%. Comparing base (8edae92) to head (a54fa57).

Files Patch % Lines
dbt_common/clients/system.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   64.31%   64.31%           
=======================================
  Files          51       51           
  Lines        3225     3228    +3     
=======================================
+ Hits         2074     2076    +2     
- Misses       1151     1152    +1     
Flag Coverage Δ
unit 64.31% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterallenwebb peterallenwebb added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 35bdf68 Jul 16, 2024
20 checks passed
@peterallenwebb peterallenwebb deleted the paw/record-groups branch July 16, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants