Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case-insensitive env vars for Windows #166

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Fix case-insensitive env vars for Windows #166

merged 4 commits into from
Jul 15, 2024

Conversation

aranke
Copy link
Member

@aranke aranke commented Jul 15, 2024

Description

Add a new CaseInsensitiveMapping class and use that for env vars on Windows.
Add a test to verify this case-insensitive mapping.

Checklist

@cla-bot cla-bot bot added the cla:yes label Jul 15, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.34%. Comparing base (6e3828e) to head (16f61ba).

Files Patch % Lines
dbt_common/context.py 73.91% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   64.31%   64.34%   +0.03%     
==========================================
  Files          51       51              
  Lines        3203     3223      +20     
==========================================
+ Hits         2060     2074      +14     
- Misses       1143     1149       +6     
Flag Coverage Δ
unit 64.34% <73.91%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aranke aranke marked this pull request as ready for review July 15, 2024 19:49
@aranke aranke requested a review from a team as a code owner July 15, 2024 19:49
@aranke aranke requested a review from peterallenwebb July 15, 2024 19:49
@aranke aranke changed the title Draft fix of case-insensitive env vars for Windows. Fix case-insensitive env vars for Windows Jul 15, 2024
@aranke aranke added this pull request to the merge queue Jul 15, 2024
Merged via the queue into main with commit 71f4d53 Jul 15, 2024
20 checks passed
@aranke aranke deleted the fix_10422 branch July 15, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants