Do not cast unscrubbed values to a string

[dbeatty10]

resolves dbt-labs/dbt-core#10421

Problem

The scrub_secrets method casts all input to str systematically, and dbt-labs/dbt-core#9733 applies the scrubbing function to all CLI variables.

This can create issues during dbt retry because all values other than str will have their data type changed.

Solution

Leave values as-is during the scrubbing process unless they contain a secret that is scrubbed out.

Checklist

• I have read the contributing guide and understand what's expected of me
• I have signed the CLA
• I have run this code in development and it appears to resolve the stated issue
• I have run changie new to create a changelog entry

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.35%. Comparing base (e1d77b6) to head (e87dd64).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   67.35%   67.35%           
=======================================
  Files          52       52           
  Lines        3370     3370           
=======================================
  Hits         2270     2270           
  Misses       1100     1100           

Flag	Coverage Δ
unit	67.35% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dbeatty10]

Thanks for taking a look at this @MichelleArk 🙏

Does the CI tests include end-to-end testing with dbt-core and dbt-postgres ? I didn't do any testing of this proposed change, so it would be good to know that existing functional tests in core and adapters still work after this change.

[MichelleArk]

It does not. dbt-core tests will run once this is on the merge queue which use dbt-postgres. The dbt-postgres integration tests are currently largely a mirror of what's in dbt-core so I don't think we'd get tons more signal by just running those.

[mmansikka]

Finally this is solved! Any update on when this PR is merged?