-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deserialize records "just in time" in order to avoid import order isssue #151
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think the failing tests are unrelated and a fix is in progress separate from this.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
=======================================
Coverage 64.30% 64.30%
=======================================
Files 51 51
Lines 3202 3202
=======================================
Hits 2059 2059
Misses 1143 1143
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
resolves CORE-308
Description
Because not all Record types may not be imported when a recording is loaded, defer deserialization until they are requested, at which time they are guaranteed to be available.
Checklist
changie new
to create a changelog entry