Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialize records "just in time" in order to avoid import order isssue #151

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

peterallenwebb
Copy link
Contributor

@peterallenwebb peterallenwebb commented Jun 18, 2024

resolves CORE-308

Description

Because not all Record types may not be imported when a recording is loaded, defer deserialization until they are requested, at which time they are guaranteed to be available.

Checklist

@peterallenwebb peterallenwebb requested a review from a team as a code owner June 18, 2024 19:49
@cla-bot cla-bot bot added the cla:yes label Jun 18, 2024
@peterallenwebb peterallenwebb changed the title Deserialize records "just in time" in order to avoid import order iss… Deserialize records "just in time" in order to avoid import order isssue Jun 18, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think the failing tests are unrelated and a fix is in progress separate from this.

@peterallenwebb peterallenwebb added this pull request to the merge queue Jun 20, 2024
@peterallenwebb peterallenwebb added this pull request to the merge queue Jun 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 20, 2024
@peterallenwebb peterallenwebb enabled auto-merge June 26, 2024 20:07
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.30%. Comparing base (dbb2308) to head (9fe6746).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   64.30%   64.30%           
=======================================
  Files          51       51           
  Lines        3202     3202           
=======================================
  Hits         2059     2059           
  Misses       1143     1143           
Flag Coverage Δ
unit 64.30% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterallenwebb peterallenwebb added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit 002377d Jun 26, 2024
17 checks passed
@peterallenwebb peterallenwebb deleted the paw/jit-record-deserialization-2 branch June 26, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants