Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement relation filtering on get_catalog macro #1073

Merged

Conversation

mikealfare
Copy link
Contributor

resolves #950

Problem

When get_catalog runs, it needs to return all relations within a schema, hence it cannot be parallelized or scale. It also means that all relations will be returned, not just those managed by dbt.

Solution

Allow for a set of relations to be passed in to limit the query against the database.

NOTE: We are releasing to 1.7.latest first, which is unusual. This PR is a set of cherry picks from #1063. The latter will be updated and merged post adapter/core split work.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Jan 17, 2024
@mikealfare mikealfare requested a review from a team as a code owner January 17, 2024 23:59
@cla-bot cla-bot bot added the cla:yes label Jan 17, 2024
@mikealfare mikealfare linked an issue Jan 17, 2024 that may be closed by this pull request
3 tasks
…7.latest

# Conflicts:
#	dbt/adapters/bigquery/impl.py
@colin-rogers-dbt colin-rogers-dbt merged commit 74f6ba5 into 1.7.latest Jan 18, 2024
22 of 24 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the applied-state/get-catalog-by-object-1.7.latest branch January 18, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-928] [Feature] Implement relation filtering on get_catalog macro
3 participants