Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Mashumaro to keep aligned with dbt core depedencies #363

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

VersusFacit
Copy link
Contributor

Per dbt-labs/dbt-core@407f6caa1c70a8ba3d8fdbddb5edb4c7afed35bc\#diff-7c83d4c4b82698e2b510b737d%5C%5B%E2%80%A6%5C%5D5b0c1e3c0cb3353460e73bcae29R54

Problem

Mashumaro 3.15 broke core builds. dbt-labs/dbt-core#11046

We need to mirror that dependency resolution.

Solution

Pin using Core's standard.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@VersusFacit VersusFacit self-assigned this Nov 25, 2024
@VersusFacit VersusFacit requested a review from a team as a code owner November 25, 2024 17:17
@VersusFacit VersusFacit changed the title Pin to align with dbt core. Pin Mashumaro to keep aligned with dbt core depedencies Nov 25, 2024
@mikealfare
Copy link
Contributor

CLA-bot is currently not working. The author is a dbt Labs employee, therefore they have signed the CLA. Merging with manual confirmation.

@mikealfare mikealfare merged commit 2793f9f into main Nov 25, 2024
11 checks passed
@mikealfare mikealfare deleted the fix_build_by_pinning_mashumaro branch November 25, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants