Fix setting of global behavior flags #348
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #351
Problem
As part of #323, we had introduced the
require_batched_execution_for_custom_microbatch_strategy
behaviour flag as part of theBaseAdapter._behavior_flags
method. However, any concrete adapters that overwrote this property effectively removed the new behaviour flag from the collection, which would lead to downstream CompilationErrors (behaviour flag not registered).Solution
Set up
require_batched_execution_for_custom_microbatch_strategy
as a global behaviour flag.Also added a test to ensure BaseAdapter._behaviour_flags is always empty to avoid this issue in the future.
Checklist