Schema/Field: add foreign_key_reference builder #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewgregory
force-pushed
the
foreign_key
branch
from
35554bc to
bbe3d27
Compare
foreign_key_reference was only being set from the is_foreign_key builder. If a user manually set is_foreign_key, as DBIx::Class does, foreign_key_reference would never be set, breaking the HTML producer.
|
@andrewgregory Can you please explain what is the exact scenario in which you find Can you please elaborate? |
|
I don't find it useful; this was really just to fix HTML output for DBIC. Although, if setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foreign_key_reference was only being set from the is_foreign_key
builder. If a user manually set is_foreign_key, as DBIx::Class does,
foreign_key_reference would never be set, breaking the HTML producer.