Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix javascript undefined error #548

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

iedex
Copy link

@iedex iedex commented Jan 23, 2020

No description provided.

@P1robot
Copy link

P1robot commented Jan 24, 2020

Automated benchmark results (pass #0): passed

concurrency: 32
requests per second: 6160
concurrency: 128
requests per second: 7641
concurrency: 512
requests per second: 4685
concurrency: 1024
requests per second: 4006

@@ -1297,8 +1297,6 @@ if (typeof(window.fuel.fields) == 'undefined'){
$(document).trigger('blockLoaded', [$this, context]);
$('#form').data('disabled', false);
});
} else {
$layout_fields.empty();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of deleting this line, I think you could move line 1287 to 1283 where it defines $layout_fields before the conditional logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants