🧪 get logs refactor #232
Merged
🧪 get logs refactor #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dawsbot The mocking data is quite large for this test. What are your thoughts on creating a directory just for storing the mocking data? For any test with a large about of mocking data we could move those objects over to the directory for storing data? |
|
Having a separate location for the mocks can be good but I also like co-locating mock data next to the test which requires it. Let me see if I can add that into this PR as an example to follow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dawsbot Another ready!
Helper function used here to keep it cleaner:
https://github.com/jtfirek/essential-eth/blob/2a96887e7d54a364f481663d9b4a13279d2bd43a/src/providers/test/json-rpc-provider/get-logs.test.ts#L182
I added it to #228 as another helper function that needs to be tested