Fix makefile to support window powershell and update readme to include contribute guide #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ruowan
changed the title
|
Would you prefer to PR this to apache/arrow-adbc directly? |
davidhcoe
approved these changes
Sep 28, 2023
davidhcoe
pushed a commit
that referenced
this pull request
Oct 5, 2023
… correctly (apache#1168) Fixes apache#1100 Test before fix: ``` Expected equality of these values: AdbcGetObjectsDataGetTableByName(&mock_data, "mock_catalog", "mock_schema", "table_suffix") Which is: 0x16d014ee8 &mock_table_suffix Which is: 0x16d014ea8 arrow-adbc/c/driver/common/utils_test.cc:220: Failure Expected equality of these values: AdbcGetObjectsDataGetColumnByName(&mock_data, "mock_catalog", "mock_schema", "table", "column_suffix") Which is: 0x16d014df8 &mock_column_suffix Which is: 0x16d014d48 arrow-adbc/c/driver/common/utils_test.cc:224: Failure Expected equality of these values: AdbcGetObjectsDataGetConstraintByName(&mock_data, "mock_catalog", "mock_schema", "table", "constraint_suffix") Which is: 0x16d014d08 &mock_constraint_suffix Which is: 0x16d014cc8 [ FAILED ] AdbcGetObjectsData.GetObjectsByName (0 ms) ``` Test after fix: ``` $ ctest Test project arrow-adbc/build Start 1: adbc-driver-common-test 1/2 Test #1: adbc-driver-common-test .......... Passed 0.25 sec Start 2: adbc-driver-sqlite-test 2/2 Test #2: adbc-driver-sqlite-test .......... Passed 0.19 sec 100% tests passed, 0 tests failed out of 2 Label Time Summary: driver-common = 0.25 sec*proc (1 test) driver-sqlite = 0.19 sec*proc (1 test) unittest = 0.43 sec*proc (2 tests) Total Test time (real) = 0.44 sec ```
davidhcoe
pushed a commit
that referenced
this pull request
Mar 15, 2024
Added implementation for table schema in SparkConnection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.