Added fix and test for write_scan_raw with omited low values for rowIndex or columnIndex #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review again. Thanks, for the suggestions via direct message! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The detailed issue description can be found here: #80
In essence: a C++ E57Exception ErrorValueOfBounds bubbled through, if written values in "rowIndex" or "columnIndex" inside write_scan_raw were all greater than zero. I had this use case, because of filtering clouds. This PR should fix the issue. Without the fix in e57.py, you can reproduce the bug with the suggested test failing. Fell free to ask for support on this. I am available. Thanks!