-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: macOS ci build wheels env variable update #67
fix: macOS ci build wheels env variable update #67
Conversation
great that's fixed it ! |
ahh no with this release now pye57 will not install properly on mac or on my Windows machine - I will revert everything for now |
What is the error you see? Also is there a way to build and test the wheels? I am able to do |
Here's the latest install on macOS.
|
Do you have xerces C installed on your mac ? For me it failed on mac with python 3.10 and no xerces C saying |
cibuildwheel should have a facility for testing wheels but I don't think we're using it right now - it would be good to add it, making sure that it uses a fresh environment without the build dependencies... |
Unsure on the windows error. Maybe the libe57 got updated and has changes around that file. Will need to dig deeper. There were no changes to the windows in my commits so not sure where that came from. For macOs, I don't have xerces installed locally, I will give it a shot on another machine. For now it will be great if you can suggest ways to test on all OS. I dont want to create VMs. |
I think adding an environment variable should do it ! https://cibuildwheel.pypa.io/en/stable/options/#test-command |
Building macOS wheels was using the wrong CIBW variable. Variable to be used is
CIBW_BEFORE_ALL_MACOS
instead ofCIBW_BEFORE_ALL_LINUX
.https://cibuildwheel.pypa.io/en/stable/options/#before-all