Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added minor updates in comments for clarity and proposed some u… #44

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maxzaikin
Copy link

Dear David,

During working on examples provided in your book, I have found that some of the code not work me. Thus I decided to make some minor changes for you to consider them as candidates for updates.
Particularly for this PR, I propose following:

  1. Highlight explicitly that some of the constants in the head of the notebook are overlap each-other
  2. Improve displaying example with faces, thus only blond-hair celebrities are shown
  3. Notify that for some versions of TF extension for checkout may be required to be different, so students should pay attention to the TF error messages
  4. Notify students that param 'steps_per_epoch=1' may be wanted to be adjusted as it provide instant inference but terrible results

Best regards,
Maks.

P.S.
Love your book. Thanks a lot and don't stop you doing great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant