Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lookup table module #2262

Merged
merged 3 commits into from
Oct 31, 2024
Merged

add lookup table module #2262

merged 3 commits into from
Oct 31, 2024

Conversation

jqnatividad
Copy link
Collaborator

luau had lookup table functionality that allowed it to fetch lookup tables from CKAN, from dathere://, from a URL, and from the filesystem with some simple caching functionality.
Extract lookup table logic into its own module so we can use it in other qsv commands.

@tino097
Copy link
Collaborator

tino097 commented Oct 31, 2024

This will work only for tables or we can use it to get the files when will be uploaded with DP+ ?

@jqnatividad
Copy link
Collaborator Author

jqnatividad commented Oct 31, 2024

Right now, it will only work with CSV files @tino097, but we can always extend it.

What did you have in mind?

@jqnatividad jqnatividad merged commit 122f8bf into master Oct 31, 2024
15 checks passed
@jqnatividad jqnatividad deleted the lookup_table_module branch October 31, 2024 10:56
@tino097
Copy link
Collaborator

tino097 commented Oct 31, 2024

Updating the fucntionality for getting the resources in DP+. Right now we are doing request download but if the resource is in the same location as the qsv it could be much faster to perform the action of pushing the data to the datastore

@jqnatividad
Copy link
Collaborator Author

Great idea! I've been thinking about a get command that fetches resources more efficiently:

  • has configurable schemes (like dathere://), so we can have it fetch from different sources (e.g. S3, minio, cloud storage, etc.)
  • with more sophisticated caching - building on the simple cache aging in lookup tables (using ETags, etc.)
  • auto compress/decompression in a local cache

Will add it to the backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants