json: change jsonp to json using new implementation
#1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| let flattener = Flattener::new(); | ||
| let mut output = Vec::<u8>::new(); | ||
| let value = match args.arg_input { | ||
| Some(path) => get_value_from_path(path.into()), |
Check warning
Code scanning / clippy
useless conversion to the same type: std::string::String Warning
Comment on lines
+92
to
+95
| let first_dict = value | ||
| .as_array() | ||
| .unwrap() | ||
| .get(0) |
Check warning
Code scanning / clippy
accessing first element with value .as_array() .unwrap().get(0) Warning
| .expect("Failed to read stdout"); | ||
|
|
||
| if let Some(output_path) = args.flag_output { | ||
| let mut file = std::fs::File::create(&output_path)?; |
Check warning
Code scanning / clippy
the borrowed expression implements the required traits Warning
|
Thanks for the quick turnaround @rzmk ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A different implementation of
qsv jsonpnow not requiringpolarsand renamed tojson. For now it mainly works with non-nested data and this PR currently hasunwrap/etc. and could be improved along with in the future potentially allowing nested data.Uses this crate: https://github.com/vtselfa/json-objects-to-csv