Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excel: minor performance tweaks #1446

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Conversation

jqnatividad
Copy link
Collaborator

  • remove unnecessary allocations in hot loop
  • compare to f64::EPSILON instead of 0.0
  • also added test for data types

- remove unnecessary allocations in hot loop
- compare to f64::EPSILON instead of 0.0
- also added test for data types
@jqnatividad jqnatividad merged commit 4d1327f into master Dec 3, 2023
src/cmd/excel.rs Dismissed Show dismissed Hide dismissed
src/cmd/excel.rs Dismissed Show dismissed Hide dismissed
@jqnatividad jqnatividad deleted the excel-types-minallocs branch December 12, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant