Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cat: faster cat rows #1407

Merged
merged 2 commits into from
Nov 9, 2023
Merged

cat: faster cat rows #1407

merged 2 commits into from
Nov 9, 2023

Conversation

jqnatividad
Copy link
Collaborator

Refactored cat rows for more performance:

  • only check for headers in first file, not repeatedly in hot loop
  • amortize rdr allocation
  • inline configs helper fn which call many_configs in utils to minimize passing vec of configs by value
  • inline many_configs
  • increase default csv write buffer from 256k to 512k to reduce expensive os write calls

Should noticeably improve cat rows performance in @derekmahar's benchmarks in #1293

@jqnatividad
cat: refactor cat rows for performance
8cb9586 
- only check for headers in first file, not repeatedly in hot loop
- amortize rdr allocation
- inline configs helper fn which call many_configs in utils to minimize passing vec of configs by value
- inline many_configs
@jqnatividad
increase default csv write buffer from 256k to 512k
bf645e7 
this should help minimize expensive os calls when writing CSV output
@jqnatividad jqnatividad merged commit 73512d7 into master Nov 9, 2023
10 checks passed
@ZhongRuoyu ZhongRuoyu mentioned this pull request Nov 20, 2023
Merged
@jqnatividad jqnatividad deleted the 1293-faster-cat-rows branch December 12, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jqnatividad