Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excel: we can now open workbooks with formulas set to an empty string value #1274

Merged
merged 2 commits into from
Sep 2, 2023

Conversation

jqnatividad
Copy link
Collaborator

When a workbook has a formula set to an empty string value, we'd get this error:

$ qsv excel resources/test/formula_empty_string_value.xls                   
Cannot open workbook: Xls error: Unrecognized error: 0x3.

with this fix, qsv can open the file.

fixes tafia/calamine#343
as we wait for calamine to merge tafia/calamine#349, we'll use patch.crates-io to use our fork with the unmerged fix so we can release qsv 0.113.0
@jqnatividad jqnatividad merged commit e391582 into master Sep 2, 2023
8 checks passed
@jqnatividad jqnatividad deleted the excel-formula-empty-string-value branch September 10, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant