Skip to content

Commit

Permalink
chore: tojsonl do not use polars-accelerated util::count_rows on Wi…
Browse files Browse the repository at this point in the history
…ndows
  • Loading branch information
jqnatividad committed Dec 14, 2024
1 parent 2ab4fb0 commit 84fc125
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions src/cmd/tojsonl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,13 @@ pub fn run(argv: &[&str]) -> CliResult<()> {
args.flag_memcheck,
)?;

// use regular CSV reader count on Windows
// as the polars-powered count_rows is failing CI tests on Windows
// I suspect there is an optimization in Polars that is causing this
// CI test flakiness
#[cfg(windows)]
let record_count = util::count_rows_regular(&conf)?;
#[cfg(not(windows))]
let record_count = util::count_rows(&conf)?;

// we're calling the schema command to infer data types and enums
Expand Down

0 comments on commit 84fc125

Please sign in to comment.