Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add oauth2/keycloak test environment #86

Merged
merged 2 commits into from
Sep 26, 2023
Merged

docs: Add oauth2/keycloak test environment #86

merged 2 commits into from
Sep 26, 2023

Conversation

dvchristianbors
Copy link
Contributor

Closes https://github.com/datavisyn/reprovisyn/issues/859

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • add oauth2/keycloak test environment and readme

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@dvchristianbors dvchristianbors added the type: docs Improvements or additions to documentation label Sep 25, 2023
@dvchristianbors dvchristianbors self-assigned this Sep 25, 2023
@dvchristianbors dvchristianbors changed the title [docs] Add oauth2/keycloak test environment docs: Add oauth2/keycloak test environment Sep 25, 2023
thinkh
thinkh approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving the documentation here.

@thinkh thinkh merged commit 86c09c8 into develop Sep 26, 2023
3 checks passed
@thinkh thinkh deleted the cb/oauth-docs branch September 26, 2023 07:42
@thinkh thinkh mentioned this pull request Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@dvchristianbors dvchristianbors

Labels
type: docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvchristianbors @thinkh