Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add context to visyn view components #79

Merged
merged 7 commits into from
Sep 26, 2023
Merged

Conversation

puehringer
Copy link
Contributor

@puehringer puehringer commented Aug 16, 2023

Requires datavisyn/visyn_scripts#38

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • Adds a context view which should render "above" all other components.

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@puehringer puehringer added the type: feature New feature or request label Aug 16, 2023
@puehringer puehringer marked this pull request as draft August 16, 2023 12:37
@puehringer puehringer force-pushed the mp/visyn_view_context branch from 79d9daf to ba792b9 Compare August 16, 2023 12:42
@puehringer puehringer marked this pull request as ready for review August 17, 2023 11:17
@puehringer puehringer added the release: patch PR merge results in a new patch version label Aug 17, 2023
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The related PR datavisyn/visyn_scripts#38 has been merged and I removed the @ts-ignore.

@thinkh thinkh merged commit 5691649 into develop Sep 26, 2023
3 checks passed
@thinkh thinkh deleted the mp/visyn_view_context branch September 26, 2023 07:46
@thinkh thinkh mentioned this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: patch PR merge results in a new patch version type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants