Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: VariableSizeList typing #656

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

puehringer
Copy link
Contributor

@puehringer puehringer commented Dec 6, 2024

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • With the latest release of @types/react, the VariableSizeList is not a "component" anymore
src/vis/bar/BarChart.tsx:420:18 - error TS2786: 'VariableSizeList' cannot be used as a JSX component.
  Its type 'typeof VariableSizeList' is not a valid JSX element type.
    Types of construct signatures are incompatible.
      Type 'new <T = any>(props: VariableSizeListProps<T>) => VariableSizeList<T>' is not assignable to type 'new (props: any, deprecatedLegacyContext?: any) => Component<any, any, any>'.
        Property 'refs' is missing in type 'VariableSizeList<any>' but required in type 'Component<any, any, any>'.

420                 <VariableSizeList
                     ~~~~~~~~~~~~~~~~

  node_modules/@types/react/index.d.ts:1033:9
    1033         refs: {
                 ~~~~
    'refs' is declared here.

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@puehringer puehringer marked this pull request as ready for review December 6, 2024 08:17
@puehringer puehringer requested a review from a team as a code owner December 6, 2024 08:17
@puehringer puehringer self-assigned this Dec 6, 2024
@puehringer puehringer added the release: patch PR merge results in a new patch version label Dec 6, 2024
@puehringer puehringer merged commit 6434da5 into develop Dec 6, 2024
12 of 15 checks passed
@puehringer puehringer deleted the mp/VariableSizeList_typing branch December 6, 2024 08:22
@github-actions github-actions bot mentioned this pull request Dec 6, 2024
puehringer added a commit that referenced this pull request Dec 6, 2024
## What's Changed
* fix: add upgrade to uv install by @puehringer in
#648
* feat(icons): add new junction icon by @dvdanielamoitzi in
#655
* fix: VariableSizeList typing by @puehringer in
#656
* feat: Celery integration by @puehringer in
#649


**Full Changelog**:
v14.3.0...14.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: patch PR merge results in a new patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant