feat(icons): add new array column icons #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the changes @dvdanielamoitzi, they look slick! |
thinkh
requested changes
Nov 20, 2024
There was a problem hiding this comment.
@dvdanielamoitzi Thanks for the array column icons. I agree with @dv-usama-ansari suggestion to rename the columns and icons to ...ArrayCol or ...ArrayColumn because while programming the s can be easily missed and causes unnecessary errors. I also corrected some oversights in the naming. Please see my suggestions.
thinkh
changed the title
Co-authored-by: Holger Stitz <[email protected]>
Co-authored-by: Holger Stitz <[email protected]>
Co-authored-by: Holger Stitz <[email protected]>
Co-authored-by: Holger Stitz <[email protected]>
thinkh
approved these changes
Nov 20, 2024
Merged
puehringer
added a commit
that referenced
this pull request
Nov 28, 2024
## What's Changed * feat: add `GenomeNavigation` class to util package by @dvmoritzschoefl in #625 * !chore: remove GenomeNavigation by @dvmoritzschoefl in #632 * Added useTriggerFrame hook by @dvmoritzschoefl in #624 * Refactored single subplot log scaling by @dvmoritzschoefl in #633 * feat(icons): add new array column icons by @dvdanielamoitzi in #639 * feat: Use pixel content values from resize observer by @dvmoritzschoefl in #640 * feat(ci): Finalize Automated Release Workflow by @dvvanessastoiber in #646 **Full Changelog**: v14.2.0...14.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Screenshots
Thanks for creating this pull request 🤗