Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored single subplot log scaling #633

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Refactored single subplot log scaling #633

merged 2 commits into from
Nov 18, 2024

Conversation

dvmoritzschoefl
Copy link
Contributor

When a single subplot was supplied to the general vis, the following problem occured:

  • A layout spec similar to the one for a single scatterplot was returned for this case, which resulted in the xaxis/yaxis keys being stale
  • Got fixed by not having this special case and instead handling everything the same way for subplots and conditionally set parameters like standoff/text truncation/grid instead

@dvmoritzschoefl dvmoritzschoefl requested a review from a team as a code owner November 18, 2024 13:33
thinkh
thinkh approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvmoritzschoefl Thanks for fixing this tricky bug. I tested this in Ordino and it works now as expected.

Single co-expression plot

image

Second co-expression plot

image

All axes remain stable in the first plot. 👍

@thinkh thinkh added release: patch PR merge results in a new patch version type: bug Something isn't working labels Nov 18, 2024
@thinkh thinkh merged commit 878649e into develop Nov 18, 2024
9 of 11 checks passed
@thinkh thinkh deleted the mh/log_scale_single_subplot branch November 18, 2024 20:32
@github-actions github-actions bot mentioned this pull request Nov 28, 2024
Merged
puehringer added a commit that referenced this pull request Nov 28, 2024
@puehringer
Release 14.3.0 (#647)
e535f73 
## What's Changed
* feat: add `GenomeNavigation` class to util package by @dvmoritzschoefl
in #625
* !chore: remove GenomeNavigation by @dvmoritzschoefl in
#632
* Added useTriggerFrame hook by @dvmoritzschoefl in
#624
* Refactored single subplot log scaling by @dvmoritzschoefl in
#633
* feat(icons): add new array column icons by @dvdanielamoitzi in
#639
* feat: Use pixel content values from resize observer by
@dvmoritzschoefl in #640
* feat(ci): Finalize Automated Release Workflow by @dvvanessastoiber in
#646


**Full Changelog**:
v14.2.0...14.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@thinkh thinkh

Labels
release: patch PR merge results in a new patch version type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvmoritzschoefl @thinkh