Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add derived Taggle for VisynRanking #35

Merged
merged 301 commits into from
Oct 25, 2023

Conversation

puehringer
Copy link
Contributor

@puehringer puehringer commented May 17, 2023

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • Adds lineup to the callback properties of the VisynRanking. Allows accessing the highlight among other things.
  • Adds SMILESColumn and renderer to visyn_core and the VisynRanking.

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@puehringer puehringer force-pushed the mp/export_taggle_in_visyn_ranking branch 2 times, most recently from 6f7dd56 to e6a62cb Compare May 17, 2023 11:39
@puehringer puehringer changed the title Add lineup instance to onBuiltLineup in VisynRanking feat: Add SMILESColumn to VisynRanking May 17, 2023
@puehringer puehringer force-pushed the mp/export_taggle_in_visyn_ranking branch from e6a62cb to 6914039 Compare May 17, 2023 11:59
@dvmoritzschoefl dvmoritzschoefl changed the base branch from develop to mantine6 May 31, 2023 12:13
Base automatically changed from mantine6 to develop June 1, 2023 08:10
@puehringer puehringer added release: minor PR merge results in a new minor version type: feature New feature or request type: refactor Refactor the current implementation labels Oct 25, 2023
@puehringer puehringer changed the title feat: Add SMILESColumn to VisynRanking feat: add derived Taggle for VisynRanking Oct 25, 2023
@puehringer puehringer merged commit 944cc0c into develop Oct 25, 2023
3 checks passed
@puehringer puehringer deleted the mp/export_taggle_in_visyn_ranking branch October 25, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: minor PR merge results in a new minor version type: feature New feature or request type: refactor Refactor the current implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants