Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vertical position of datavisyn logo in visyn header #193

Merged
merged 2 commits into from
Feb 22, 2024
Merged

fix: vertical position of datavisyn logo in visyn header #193

merged 2 commits into from
Feb 22, 2024

Conversation

dvdanielamoitzi
Copy link
Contributor

Closes list issues numbers here

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@dvdanielamoitzi dvdanielamoitzi changed the title fix: vertical position of datavisyn logo fix: vertical position of datavisyn logo in visyn header Feb 22, 2024
thinkh
thinkh approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. We tested this together in different apps and it looks good now.

@thinkh thinkh merged commit 7b13338 into develop Feb 22, 2024
4 checks passed
@thinkh thinkh deleted the dmoitzi/fix-logo-position-in-visyn-header branch February 22, 2024 13:13
@thinkh thinkh mentioned this pull request Feb 22, 2024
Merged
thinkh added a commit that referenced this pull request Feb 22, 2024
@thinkh
Release 8.1.1 (#194)
f26cff0 
## What's Changed
* fix: vertical position of datavisyn logo in visyn header by
@dvdanielamoitzi in #193
* fix(vis): transparent scatterplot labels by @dv-raghad-jamalaldeen in
#192


**Full Changelog**:
v8.1.0...v8.1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@thinkh thinkh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvdanielamoitzi @thinkh