Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: language strings #122

Merged
merged 4 commits into from
Nov 20, 2023
Merged

fix: language strings #122

merged 4 commits into from
Nov 20, 2023

Conversation

dv-usama-ansari
Copy link
Contributor

Closes Language strings of #99

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified @dvdanielamoitzi
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • Fixed the error messages in Correlation and Raincloud plot

Screenshots

Screenshot from 2023-11-17 09-42-25
Screenshot from 2023-11-17 09-42-04

Additional notes for the reviewer(s)

  • N/A
    Thanks for creating this pull request 🤗

@dv-usama-ansari dv-usama-ansari linked an issue Nov 17, 2023 that may be closed by this pull request
Various bugs vis components #99
Closed
9 tasks
@dv-usama-ansari dv-usama-ansari self-assigned this Nov 17, 2023
@dv-usama-ansari dv-usama-ansari added release: patch PR merge results in a new patch version type: refactor Refactor the current implementation labels Nov 17, 2023
@dvdanielamoitzi dvdanielamoitzi merged commit aec82b0 into develop Nov 20, 2023
4 checks passed
@dvdanielamoitzi dvdanielamoitzi deleted the ua/99-fix-language-strings branch November 20, 2023 16:04
@dv-usama-ansari dv-usama-ansari mentioned this pull request Nov 20, 2023
Closed
9 tasks
@thinkh thinkh mentioned this pull request Nov 21, 2023
Merged
thinkh added a commit that referenced this pull request Nov 21, 2023
@thinkh
Release 6.0.0 (#126)
1efdfa3 
## What's Changed
* fix: fix storybook by wrapping all Vis in VisProvider by
@dvmartinweigl in #101
* feat: prevent csv injection in xlsx export by @dvmartinweigl in
#108
* deps: Node 20 and no_dist by @puehringer in
#107
* feat: Extended ISingleScoreResult to except column desc directly by
@dvtschachinger in #113
* fix: bar chart crash issue in Various bugs vis components #99 by
@dv-usama-ansari in #119
* refactor: log entire token payload if no email field matched by
@puehringer in #111
* deps: add @emotion/react by @puehringer in
#124
* fix: language strings by @dv-usama-ansari in
#122
* fix: hide filter if no callback is provided by @dv-usama-ansari in
#117
* fix: violin plot x-axis labels misalignment by @dv-usama-ansari in
#123

## New Contributors
* @dvmartinweigl made their first contribution in
#101

**Full Changelog**:
v5.0.0...v6.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvmartinweigl dvmartinweigl dvmartinweigl approved these changes

@dvdanielamoitzi dvdanielamoitzi dvdanielamoitzi approved these changes

@thinkh thinkh thinkh approved these changes

Assignees

@dv-usama-ansari dv-usama-ansari

Labels
release: patch PR merge results in a new patch version type: refactor Refactor the current implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Various bugs vis components
4 participants
@dv-usama-ansari @thinkh @dvdanielamoitzi @dvmartinweigl