Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: pin @types/react to 18.2.31 #103

Merged
merged 1 commit into from
Oct 25, 2023
Merged

deps: pin @types/react to 18.2.31 #103

merged 1 commit into from
Oct 25, 2023

Conversation

puehringer
Copy link
Contributor

@puehringer puehringer commented Oct 25, 2023 •
edited
Loading

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@puehringer puehringer mentioned this pull request Oct 25, 2023
Closed
17 tasks
@puehringer puehringer added release: patch PR merge results in a new patch version dependencies Pull requests that update a dependency file labels Oct 25, 2023
@puehringer puehringer changed the title Pin @types/react to 18.2.31 deps: pin @types/react to 18.2.31 Oct 25, 2023
@puehringer puehringer merged commit 394cae8 into develop Oct 25, 2023
3 checks passed
@puehringer puehringer deleted the mp/pin_react_types_18_2_31 branch October 25, 2023 15:48
@puehringer puehringer mentioned this pull request Oct 27, 2023
Merged
puehringer added a commit that referenced this pull request Oct 27, 2023
@puehringer
Revert "deps: pin @types/react to 18.2.31" (#105)
ce8c6e7 
Reverts #103, because the breaking change in
DefinitelyTyped/DefinitelyTyped#67132 is
reverted as well.
@dvvanessastoiber dvvanessastoiber mentioned this pull request Oct 31, 2023
Merged
2 tasks
puehringer added a commit that referenced this pull request Oct 31, 2023
@puehringer
Release 5.0.0 (#106)
7e6d922 
## Release notes
* deps: pin @types/react to 18.2.31
(#103)
* Revert "deps: pin @types/react to 18.2.31"
(#105)


### Release dependencies first

In case of dependent Phovea/TDP repositories follow [dependency
tree](https://wiki.datavisyn.io/phovea/fundamentals/development-process#dependency-hierarchy)
from the top:

 
### 🏁 Finish line

* [ ] Inform colleagues and customers about the release
* [ ] Celebrate the new release 🥳
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dv-usama-ansari dv-usama-ansari Awaiting requested review from dv-usama-ansari

Assignees

@dv-usama-ansari dv-usama-ansari

Labels
dependencies Pull requests that update a dependency file release: patch PR merge results in a new patch version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puehringer @dv-usama-ansari