Skip to content

Commit

Permalink
fix: filter visibility issue
Browse files Browse the repository at this point in the history
  • Loading branch information
dv-usama-ansari committed Nov 20, 2023
1 parent 1e884f6 commit 44ccecd
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 27 deletions.
11 changes: 2 additions & 9 deletions src/vis/bar/BarVisSidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -96,15 +96,8 @@ export function BarVisSidebar({
<BarDirectionButtons callback={(direction: EBarDirection) => setConfig({ ...config, direction })} currentSelected={config.direction} />
)
: null}
{filterCallback ? (
mergedOptionsConfig.filter.enable ? (
mergedOptionsConfig.filter.customComponent ? (
mergedOptionsConfig.filter.customComponent
) : null
) : (
<FilterButtons callback={filterCallback} />
)
) : null}

{filterCallback && mergedOptionsConfig.filter.enable ? mergedOptionsConfig.filter.customComponent || <FilterButtons callback={filterCallback} /> : null}
</>
);
}
10 changes: 1 addition & 9 deletions src/vis/scatter/ScatterVisSidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,7 @@ export function ScatterVisSidebar({ config, optionsConfig, columns, filterCallba
currentValue={config.alphaSliderVal}
/>

{filterCallback ? (
mergedOptionsConfig.filter.enable ? (
mergedOptionsConfig.filter.customComponent ? (
mergedOptionsConfig.filter.customComponent
) : null
) : (
<FilterButtons callback={filterCallback} />
)
) : null}
{filterCallback && mergedOptionsConfig.filter.enable ? mergedOptionsConfig.filter.customComponent || <FilterButtons callback={filterCallback} /> : null}
</>
);
}
10 changes: 1 addition & 9 deletions src/vis/violin/ViolinVisSidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,7 @@ export function ViolinVisSidebar({
)
: null}

{filterCallback ? (
mergedOptionsConfig.filter.enable ? (
mergedOptionsConfig.filter.customComponent ? (
mergedOptionsConfig.filter.customComponent
) : null
) : (
<FilterButtons callback={filterCallback} />
)
) : null}
{filterCallback && mergedOptionsConfig.filter.enable ? mergedOptionsConfig.filter.customComponent || <FilterButtons callback={filterCallback} /> : null}
</>
);
}

0 comments on commit 44ccecd

Please sign in to comment.