fix: reinvestigate margin misalignment error

datavisyn · Nov 20, 2023 · 358ee11 · 358ee11
1 parent c95a51c
commit 358ee11
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 14 deletions.
diff --git a/src/vis/general/layoutUtils.ts b/src/vis/general/layoutUtils.ts
@@ -52,15 +52,15 @@ export function beautifyLayout(traces: PlotlyInfo, layout: Partial<PlotlyTypes.L
     layout[`xaxis${i > 0 ? i + 1 : ''}`] = {
       range: t.xDomain ? t.xDomain : null,
       ...oldLayout?.[`xaxis${i > 0 ? i + 1 : ''}`],
-      // automargin,
-      rangemode: 'tozero',
-      // tickvals: t.xTicks,
-      // ticktext: t.xTickLabels,
-      // text: t.xTicks,
-      // showline: false,
-      // showspikes: false,
-      // spikedash: 'dash',
-      // ticks: 'outside',
+      automargin,
+      // rangemode: 'tozero',
+      tickvals: t.xTicks,
+      ticktext: t.xTickLabels,
+      text: t.xTicks,
+      showline: false,
+      showspikes: false,
+      spikedash: 'dash',
+      ticks: 'outside',
       title: {
         standoff: 5,
         text: traces.plots.length > 1 ? truncateText(t.xLabel, 15) : truncateText(t.xLabel, 50),

diff --git a/src/vis/violin/ViolinVis.tsx b/src/vis/violin/ViolinVis.tsx
@@ -55,9 +55,9 @@ export function ViolinVis({ config, columns, scales, dimensions, selectedList, s
     if (plotDiv) {
       Plotly.Plots.resize(plotDiv);
     }
-  }, [id, dimensions]);
+  }, [id, dimensions, traces]);
 
-  React.useEffect(() => {
+  useEffect(() => {
     if (!traces) {
       return;
     }
@@ -84,9 +84,7 @@ export function ViolinVis({ config, columns, scales, dimensions, selectedList, s
       shapes: [],
     };
 
-    setLayout({ ...layout, ...beautifyLayout(traces, innerLayout, layout, true) });
-    // WARNING: Do not update when layout changes, that would be an infinite loop.
-    // eslint-disable-next-line react-hooks/exhaustive-deps
+    setLayout((prev: Partial<Plotly.Layout>) => ({ ...prev, ...beautifyLayout(traces, innerLayout, prev, true) }));
   }, [traces]);
 
   return (