Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data change alerting #566

Draft
wants to merge 48 commits into
base: develop
Choose a base branch
from
Draft

Data change alerting #566

wants to merge 48 commits into from

Conversation

dvtschachinger
Copy link
Contributor

alert

This is how far I got by now. What I should fix next is the bugging accordion (which one should be open when) and that alerts are not "run" automatically when created.
Also removed the hard codings from the range filter.

There are still some lint errors I didn't know how to correct properly (build error).

puehringer and others added 14 commits October 11, 2021 13:57
@puehringer
Initial backend integration of CDC
93f3326
@dvtschachinger
add CDCFilterDialog + refactor for FilterComponents + try eval query
2538a0e
@dvtschachinger
minor style improvements
72056a8
@dvtschachinger
create sqlalchemy schema + endpoints for backend + minor changes to a…
2d665c0 
…lert dialog
@dvtschachinger
minor backend changes + improving filter dialog + getting endpoints i…
64a0fc7 
…n ts working
@dvtschachinger
alignments in UI + send formdata of dialog to backend
ce35184
@dvtschachinger
refactoring filter components to split jsonify and functions + UI imp…
c892110 
…rovements
@dvtschachinger
refactor components + finalizing first draft of functionality & desig…
d165848 
…n of filter dialog
@dvtschachinger
improve UI + add running alerts in frontend
c3a223c
@dvtschachinger
tslint errors
5b639dc
@dvtschachinger
add backend concept + some UI improvements + add confirm button to ed…
3eb360b 
…it dialog
@dvtschachinger
make range slider less hardcoded + improve UI
a9b58be
@dvtschachinger
minor style changes
1e41275
@dvtschachinger
lint errors
82332d4
@dvtschachinger
Copy link
Contributor Author

I know solved all the problems except the lint errors for the circleci builds.
Also improved the deep_diff output, improved the UI a bit and it now visualizes not only new ids but also details of the new objects, removed once and changed data.

@puehringer
Copy link
Contributor

@dvtschachinger Regarding the linting:
You can change the lint command in the package.json to tslint --fix ... to autofix all fixable issues. You shouldn't check it in though because then the linting happens during CI (i.e. nothing happens).
The variable names (react components exported as const) can be temporalily disabled via

// tslint:disable-next-line:variable-name

For the backend, you can always docker-compose exec api bash, then cd tdp_core and then flake8 to test the linting live.

dvmarkusvogl and others added 19 commits November 9, 2021 13:22
@dvmarkusvogl
Merge remote-tracking branch 'origin/mv/cdc_filter' into data_change_…
9b643f3 
…alerting

# Conflicts:
#	tdp_core/cdc/schema/FieldFilterMixin.py
@dvmarkusvogl
Backend filters: Remove name from filters (only used in UI), rename c…
5a9e2d5 
…omponentId to type

API: Move /test to /alert endpoint for easier testing, and enhance users
Fix checkbox filter
@dvtschachinger
style improvement of filtercards + combine CDCCreateAlert + CDCEditAl…
4c9e66e 
…ert + make checkbox- & textfilter fitting for the backend
@puehringer
Merge branch 'develop' into data_change_alerting
be37282
@puehringer
Unified front- and backend for CDCs
6ea78fc
@dvtschachinger
code refactoring + bug fix
6d92646
@dvtschachinger
combine all single cdc filter dependecies in one dict entered by cdci…
bded9a5 
…d + minor fixes
@dvtschachinger
add error handling to several endpoints + bug fixes
7ec5c8e
@dvtschachinger
filter error
96a9169
@puehringer
Removed CDCManager and stuff
6b35346
@puehringer
Fixed stale state issue with React DnD
6d0a580
@dvmarkusvogl
Temporary commit for merging
ad9c55b
@puehringer @dvmarkusvogl
Temporary commit for merging
b4b8d34
@puehringer
Merge branch 'develop' into data_change_alerting
641145e
@puehringer
Changed back to MyDict because edit/persist did not work
d0040af
@puehringer
Merge branch 'tschachinger/cdc_UI_improvements' into data_change_aler…
6a19036 
…ting
@dvmarkusvogl
Add better configurable scheduling for mail and cdc update
87fe0f6 
Add email support and first email template
Fix filters (remove mydict)
Flake8 fix stuff
@puehringer
Merge branch 'develop' into data_change_alerting
e2b652a
@puehringer
Migrated to latest useAsync
eab2004
@puehringer puehringer marked this pull request as draft November 26, 2021 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puehringer puehringer Awaiting requested review from puehringer

At least 1 approving review is required to merge this pull request.

Assignees

@puehringer puehringer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dvtschachinger @puehringer @dvmarkusvogl