Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic release part 2 #116

Merged
merged 9 commits into from
Nov 28, 2024
Merged

Automatic release part 2 #116

merged 9 commits into from
Nov 28, 2024

Conversation

dvviktordelev
Copy link
Contributor

Copy link
Contributor

@dvvanessastoiber dvvanessastoiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvviktordelev Thank you for implementing the feedback! I just tested the workflow and it fails due to an issue parsing the JSON: https://github.com/datavisyn/test-app/actions/runs/11802941712/job/32879764274. Please take another look at this. Additionally, it would be good if these steps fail if they are not successful (the build succeeded although one of the steps failed). Thank you!

@dvviktordelev
Copy link
Contributor Author

@dvvanessastoiber fix committed

@dvvanessastoiber
Copy link
Contributor

@dvvanessastoiber fix committed

Thanks @dvviktordelev! We still have the same issue unfortunately: https://github.com/datavisyn/test-app/actions/runs/11803159213/job/32880501231 (the tag is created correctly but not the Github Release). And the build succeeds although I would expect it to fail in this case

@dvvanessastoiber dvvanessastoiber self-requested a review November 15, 2024 07:05
@dvviktordelev
Copy link
Contributor Author

@dvvanessastoiber we could also unify the release.yml and release-post-merge.yml into one.

looks like this and works too

Copy link
Contributor

@dvvanessastoiber dvvanessastoiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you very much!

@dvvanessastoiber dvvanessastoiber merged commit 64a89ee into main Nov 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants