-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic release part 2 #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dvviktordelev Thank you for implementing the feedback! I just tested the workflow and it fails due to an issue parsing the JSON: https://github.com/datavisyn/test-app/actions/runs/11802941712/job/32879764274. Please take another look at this. Additionally, it would be good if these steps fail if they are not successful (the build succeeded although one of the steps failed). Thank you!
@dvvanessastoiber fix committed |
Thanks @dvviktordelev! We still have the same issue unfortunately: https://github.com/datavisyn/test-app/actions/runs/11803159213/job/32880501231 (the tag is created correctly but not the Github Release). And the build succeeds although I would expect it to fail in this case |
@dvvanessastoiber we could also unify the release.yml and release-post-merge.yml into one. looks like this and works too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you very much!
closes https://github.com/datavisyn/infrastructure-k8s/issues/319#issuecomment-2454523041