Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ManagedLedger proto to use lightproto instead of protobuf #266

Closed
wants to merge 12 commits into from

Conversation

dlg99
Copy link
Collaborator

@dlg99 dlg99 commented May 14, 2024

Motivation

Speed up protobuf operations, reduce GC pressure

Modifications

Switched managedLedger subproject to lightproto, updated API usage

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

NO

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@dlg99 dlg99 marked this pull request as draft May 15, 2024 00:19
@dlg99 dlg99 marked this pull request as ready for review May 15, 2024 03:32
@dlg99
Copy link
Collaborator Author

dlg99 commented May 16, 2024

bad idea :)

@dlg99 dlg99 closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant