Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded DiffData to skip corrected-diff on rerun with previous-run-id #303

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Upgraded DiffData to skip corrected-diff on rerun with previous-run-id #303

merged 4 commits into from
Sep 11, 2024

Conversation

pravinbhat
Copy link
Collaborator

@pravinbhat pravinbhat commented Sep 10, 2024 •
edited
Loading

What this PR does: Skip corrected-diff on Validation rerun with previous-run-id

Checklist:

  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@pravinbhat pravinbhat requested a review from a team as a code owner September 10, 2024 17:15
msmygit
msmygit previously approved these changes Sep 10, 2024
View reviewed changes
@msmygit msmygit dismissed their stale review September 10, 2024 17:22

CI failed

@pravinbhat pravinbhat requested a review from msmygit September 10, 2024 17:41
@msmygit msmygit enabled auto-merge (squash) September 11, 2024 02:05
msmygit
msmygit approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@msmygit msmygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@msmygit msmygit merged commit 2d7d2df into main Sep 11, 2024
8 checks passed
@msmygit msmygit deleted the feature/skip-corrected-diff-on-rerun branch September 11, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faizalrub-datastax faizalrub-datastax faizalrub-datastax approved these changes

@msmygit msmygit msmygit approved these changes

@jeromatron jeromatron Awaiting requested review from jeromatron jeromatron is a code owner automatically assigned from datastax/cdm-core

@Jeremya Jeremya Awaiting requested review from Jeremya Jeremya is a code owner automatically assigned from datastax/cdm-core

@mfmaher2 mfmaher2 Awaiting requested review from mfmaher2 mfmaher2 is a code owner automatically assigned from datastax/cdm-core

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pravinbhat @msmygit @faizalrub-datastax