UKG - Added Code to fetch Astra Database Connection Details #293
Conversation
pradeepiimt
requested review from
jeromatron,
Jeremya,
pravinbhat and
Ankitp1342
There was a problem hiding this comment.
@pradeepiimt - thank you for sending in a PR, much appreciated!
I don't understand what is the background for this change. Could you add
- a detailed description,
- sign the CLA,
- provide additional details on what you're trying to achieve here
- what is prohibited today if we don't have this capability,
- what about Azure & AWS secret managers?
- add unit tests for the functionality that you're attempting to add here
such that we can review it to see how it will be useful to CDM and can incorporate the changes?
| @@ -278,17 +300,17 @@ | |||
| <limit> | |||
| <counter>COMPLEXITY</counter> | |||
| <value>COVEREDRATIO</value> | |||
| <minimum>0.33</minimum> | |||
| <minimum>0.20</minimum> | |||
There was a problem hiding this comment.
Please add unit tests in order to meet the standard minimum as opposed to reducing this.
| </limit> | ||
| <limit> | ||
| <counter>INSTRUCTION</counter> | ||
| <value>COVEREDRATIO</value> | ||
| <minimum>45%</minimum> | ||
| <minimum>35%</minimum> |
| </limit> | ||
| <limit> | ||
| <counter>LINE</counter> | ||
| <value>MISSEDCOUNT</value> | ||
| <maximum>1400</maximum> | ||
| <maximum>1500</maximum> |
| @@ -25,16 +25,19 @@ | |||
| # | |||
| #********************************************************************************************************** | |||
| #********************************************************************************************************** | |||
| spark.cdm.connect.gcp.secret.project.id | |||
There was a problem hiding this comment.
we should not just add entries here, but we also need to add them to cdm-detailed.properties file too. Thinking about this change, I think, this can only go to the other file and not stay here.
msmygit
added
enhancement
|
Hi @pradeepiimt |
…ls from GSM
What this PR does: Added Code to fetch Astra Database Connection Details
Which issue(s) this PR fixes:
Fixes #
Checklist: