Feature/transform fields #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… & skip everything else.
pravinbhat
requested review from
jeromatron,
Jeremya,
Ankitp1342,
msmygit,
mfmaher2,
faizalrub-datastax and
mieslep
Ankitp1342
approved these changes
Aug 23, 2024
Jeremya
approved these changes
Aug 23, 2024
mieslep
reviewed
Aug 26, 2024
| private List<Integer> correspondingIndexes; | ||
| private final List<Integer> counterIndexes; | ||
| protected Map<Featureset, Feature> featureMap; | ||
| public Logger logger = LoggerFactory.getLogger(this.getClass().getName()); |
There was a problem hiding this comment.
Can you make this whole file change be smaller - it is difficult to understand what has actually changed in this PR?
msmygit
approved these changes
Aug 26, 2024
| @@ -366,6 +366,27 @@ spark.cdm.perfops.ratelimit.target 20000 | |||
| #spark.cdm.feature.explodeMap.target.name.key my_map_key | |||
| #spark.cdm.feature.explodeMap.target.name.value my_map_value | |||
|
|
|||
|
|
|||
| #=========================================================================================================== | |||
There was a problem hiding this comment.
Could we please add an example here on how it will look like? I know we haven't provided examples at other properties, but this is a bit nuanced and may help users understand how it could be used. Thank you in advance!
msmygit
approved these changes
Aug 26, 2024
msmygit
reviewed
Aug 26, 2024
* Cassandra bump to 5.0-rc1 * Bump Spark to 3.5.2
mieslep
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports extracting value from a JSON column in Origin and map it to a specific field on Target
Checklist: