Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 #220

Closed
wants to merge 3 commits into from
Closed

Patch 1 #220

wants to merge 3 commits into from

Conversation

icaredb
Copy link

@icaredb icaredb commented Nov 15, 2023

What this PR does:
Fix issue 218 writetime and TTL are not preserved if columns are not explicitly configured in cdm.properties

Which issue(s) this PR fixes:
Fixes #218

Checklist:

  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@icaredb icaredb requested a review from a team as a code owner November 15, 2023 06:56
Suggested fix for the following issue:
datastax#218
writetime and TTL are not preserved if columns are not explicitly configured in cdm.properties
Fix for Jira datastax#218
writetime and TTL are not preserved if columns are not explicitly configured in cdm.properties
@msmygit
Copy link
Collaborator

msmygit commented Dec 7, 2023

@icaredb, thank you for identifying an issue, and promptly working on the fix. It looks like the test for counters failed here. Would you be able to run it locally to fix the same and push it up?

@pravinbhat
Copy link
Collaborator

Changes look good but we may need additional test coverage to get past the build error. Also needs to pull in the latest changes from main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

writetime and TTL are not preserved if columns are not explicitly configured in cdm.properties
3 participants