Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PretrainedHFTransformer can use GPUs #88

Merged
merged 3 commits into from
Nov 17, 2023
Merged

PretrainedHFTransformer can use GPUs #88

merged 3 commits into from
Nov 17, 2023

Conversation

kkovary
Copy link
Contributor

@kkovary kkovary commented Nov 17, 2023 •
edited by maclandrol
Loading

closes #87

Changelogs

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation if a new function is added, or an existing one is deleted. Eventually consider making a new tutorial for new features.
  • Write concise and explanatory changelogs below.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

discussion related to that PR

@kkovary kkovary changed the title PretrainedHFTransformer can use gpu device PretrainedHFTransformer can use GPUs Nov 17, 2023
maclandrol
maclandrol approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@maclandrol maclandrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

molfeat/trans/pretrained/hf_transformers.py Outdated Show resolved Hide resolved
@maclandrol maclandrol merged commit c4eb5df into datamol-io:main Nov 17, 2023
3 checks passed
@kkovary kkovary deleted the 87-pretrained-hf-transformer-with-gpu-device branch November 17, 2023 22:27
@kkovary kkovary mentioned this pull request Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maclandrol maclandrol maclandrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

device arg for PretrainedHFTransformer doesn't seem to do anything
2 participants
@kkovary @maclandrol