Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Molecular transformer dataframe input #77

Conversation

thibaultvarin-r
Copy link
Contributor

Changelogs

  • enumerate the changes of that PR.
    In MoleculeTransformer.transform,
  • If mols is a dataframe, then the first column of this dataframe is saved in mols as a pd.Series.
  • Also features generated are passed to utils.check_array from scikit-learn and then returned

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation if a new function is added, or an existing one is deleted. Eventually consider making a new tutorial for new features.
  • Write concise and explanatory changelogs below.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

discussion related to that PR
It was discussed first with @maclandrol and Ben Fogelson.

@maclandrol maclandrol changed the base branch from main to model-store September 5, 2023 12:56
@maclandrol maclandrol merged commit 4bb511b into datamol-io:model-store Sep 5, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants