Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly set base model to eval mode #104

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

cabreraalex
Copy link
Contributor

Changelogs

  • enumerate the changes of that PR.

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation if a new function is added, or an existing one is deleted. Eventually consider making a new tutorial for new features.
  • Write concise and explanatory changelogs below.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

discussion related to that PR

@maclandrol
Copy link
Member

Good catch !

Thanks @cabreraalex , can you run the ruff linter, otherwise will do it and merge early tomorrow.

@cabreraalex
Copy link
Contributor Author

Ruff seems to be from other areas, maybe easier for you!

I also had another issue with this part of the code - calling from_pretrained calls the DGLModel constructor with None store which causes it to instantiate and hangs for a long time failing to connect to GCP. IDK what the correct fix is, right now I'm passing in a random string as the store option to get it to not do that

@maclandrol
Copy link
Member

Can pull from main after #105 is merged.

I also had another issue with this part of the code - calling from_pretrained calls the DGLModel constructor with None store which causes it to instantiate and hangs for a long time failing to connect to GCP. IDK what the correct fix is, right now I'm passing in a random string as the store option to get it to not do that

Would you be able to share a snippet and also the system you are running on ? A lot of people seems to have issues with GCP on colab in particular.

@maclandrol maclandrol merged commit d787602 into datamol-io:main Sep 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants