Check for required querystring parameters, handle invalid values #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hancush
commented
Aug 27, 2024
Comment on lines
+83
to
+90
| if not query or not set(query.keys()) == {"document_url", "filename"}: | ||
| abort(400) | ||
|
|
||
| document_url, = query['document_url'] | ||
| filename, = query['filename'] | ||
| try: | ||
| (document_url,) = query["document_url"] | ||
| (filename,) = query["filename"] | ||
| except ValueError: | ||
| abort(400) |
There was a problem hiding this comment.
These are the only code changes.
antidipyramid
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a class of Sentry errors arising from bad requests to the PIC endpoints. I'm fairly certain these requests are made by bots, because I've done an audit of the PIC links constructed in the code, and they are formed correctly.
This PR also applies Black formatting to
app.pyand pins Werkzeug for compatibility with Flask.Connects Metro-Records/la-metro-councilmatic#1149