Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling custom kernels for Cell.tsx (#332) (0.17.x) #334

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

MarcosVn
Copy link
Contributor

Implements the solution proposed for #332

@MarcosVn
Copy link
Contributor Author

MarcosVn commented Dec 10, 2024

Hey @echarles, I implemented the solution for #332. Could you review it when possible?

One possible issue is that we are currently using version 0.17.0 in our project. Would it be possible to have a parallel branch with version 0.17.1 including this enhancement? We intend to update the version on our side, but we wouldn’t be able to do it immediately.

@echarles
Copy link
Member

Hi @MarcosVn Cell.tsx has conflict, would be great to solve that so I can review.

Happy to maintain a branch for you while you upgrade at some point.

@MarcosVn
Copy link
Contributor Author

MarcosVn commented Dec 10, 2024

Hey @charles, I believe the conflict is happening because I'm pointing the pull request to the main branch and created it from 0.17.0.

Would you prefer to create the 0.17.x branch, or should I do it here?

Once we integrate this, I can open a second pull request to main as well, so we can have this update in both places.

What do you think?

@echarles
Copy link
Member

We don't maintain tags for now. If you provide me with the exact commit, I can create a 0.17.x branch.

Yes, a second pr on main will be great.

@MarcosVn
Copy link
Contributor Author

@echarles the commit is: 3ac5b26

As soon as the 0.17.x branch is created, I’ll point this PR to it and create the new branch for main, letting you know. Thanks in advance!

@echarles
Copy link
Member

@MarcosVn MarcosVn changed the base branch from main to 0.17.x December 11, 2024 12:35
@MarcosVn MarcosVn changed the title Enabling custom kernels for Cell.tsx (#332) Enabling custom kernels for Cell.tsx (#332) (0.17.x) Dec 11, 2024
@MarcosVn
Copy link
Contributor Author

Hey @echarles, I updated this PR to point to 0.17.x and created #336 for merging with main.

The conflicts here have been resolved, feel free to review.

Thank you!

Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thx @MarcosVn

@echarles echarles merged commit c71f19d into datalayer:0.17.x Dec 11, 2024
1 check passed
@echarles
Copy link
Member

Thank you @MarcosVn

@MarcosVn
Copy link
Contributor Author

@echarles, would it be feasible to generate a version 0.17.1 with the evolution from the 0.17.x branch?

@echarles
Copy link
Member

@MarcosVn This is done in https://www.npmjs.com/package/@datalayer/jupyter-react/v/0.17.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants