-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling custom kernels for Cell.tsx (#332) (0.17.x) #334
Conversation
Hey @echarles, I implemented the solution for #332. Could you review it when possible? One possible issue is that we are currently using version |
Hi @MarcosVn Cell.tsx has conflict, would be great to solve that so I can review. Happy to maintain a branch for you while you upgrade at some point. |
Hey @charles, I believe the conflict is happening because I'm pointing the pull request to the Would you prefer to create the Once we integrate this, I can open a second pull request to What do you think? |
We don't maintain tags for now. If you provide me with the exact commit, I can create a 0.17.x branch. Yes, a second pr on main will be great. |
@MarcosVn https://github.com/datalayer/jupyter-ui/tree/0.17.x is available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thx @MarcosVn
Thank you @MarcosVn |
@echarles, would it be feasible to generate a version 0.17.1 with the evolution from the 0.17.x branch? |
Implements the solution proposed for #332