-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added notifyOnComplete parameter for KernelExecutor #291
Conversation
…model notifications only when all code execution completed
@sok82 Change look good overall. Build on CI complains with |
@sok82 another PR builds fine, so I think the failure is coming from these changes. I would prefer if possible to have it fixed before merging. |
Hey @echarles, I committed a fix for the error in this commit - 5fb5027 Some new parameter I had to just pass an empty metadata object to make it compile cause I don't have anything similar in context, not sure if it's correct. Pls check |
Sounds super cool Changes lgtm, still an build error on the CI
|
Sorry, had to work in blind mode - committed fix for this - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thx @sok82
Added notifyOnComplete parameter for code execution enabling to send model notifications only when all code execution completed and execution phase is defined
Possible solve for #290