Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds invalidate method to MemCacheMapping #10

Merged
merged 6 commits into from
Oct 3, 2023
Merged

Adds invalidate method to MemCacheMapping #10

merged 6 commits into from
Oct 3, 2023

Conversation

rber474
Copy link
Contributor

@rber474 rber474 commented Sep 19, 2023

Adds invalidate method to MemCacheMapping class, trying to fix #8

@rber474
Copy link
Contributor Author

rber474 commented Sep 19, 2023 •
edited
Loading

Tests passed.
Not my day, sorry.

dataflake
dataflake requested changes Oct 2, 2023
View reviewed changes
Copy link
Owner

@dataflake dataflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing unit tests and a change log entry.

@rber474
Copy link
Contributor Author

rber474 commented Oct 2, 2023

added unittest and log entry

@dataflake dataflake merged commit 214aa68 into dataflake:master Oct 3, 2023
8 checks passed
@dataflake
Copy link
Owner

Thank you for your help on this, version 4.1 is now published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataflake dataflake dataflake approved these changes

@erral erral erral approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError: 'MemCacheMapping' object has no attribute 'invalidate'
3 participants
@rber474 @dataflake @erral